search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
223 stars 235 forks source link

nsinker: set pressure scaling to 1.0 #5772

Closed tjhei closed 4 months ago

tjhei commented 4 months ago

using #5761

tjhei commented 4 months ago

Are there nsinker tests? Do they use the new pressure scaling?

Yes. Yes, they should. I am waiting for the tester to tell me how to update... :-)

tjhei commented 4 months ago

Fascinating. It looks like no test is affected by it. This is probably because the tests are too coarse to trigger a difference in iteration numbers.

tjhei commented 4 months ago

If the change in pressure scaling is small enough to not affect the tests that is alright.

The pressure scaling in nsinker is around 10 when I checked. Maybe on coarse meshes it is even less.