search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
223 stars 235 forks source link

change boundary conditions to dirichlet 0 for nsinker benchmark #5773

Closed quangx closed 4 months ago

quangx commented 4 months ago

nsinker.cc says the benchmark is meant to be as defined in Rudi et al. (2017), which uses Dirichlet 0 boundary conditions. This is also consistent with the boundary conditions implemented for the sinker problem in Clevenger, Heister (2021).

tjhei commented 4 months ago

You will need to update test output.

/rebuild

bangerth commented 4 months ago

I admit that my request is pedantic, but I'd still like to ask for one change.

quangx commented 4 months ago

I did the reorder, ready to be reviewed again.