geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
223 stars 235 forks source link

Implementing Clinopyroxene (CPX) slip systems into the DRex CPO plugin #5779

Closed magmaxt closed 4 months ago

magmaxt commented 4 months ago

Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.

Describe what you did in this PR and why you did it. (related issue #3885)

  1. I tested both the old LPO and the new CPO plugins for calculating Olivine A,B,C,E fabrics under simple shear. The results are consistent with Fraters and Billen 2021. Published results using LPO: image Old LPO and new CPO results: image

  2. I added CPX slip systems into the DRex CPO plugin and reproduced the three types of fabrics from lab experiments (Zhang et al., 2006)and observed xenolith fabrics. image image image

  3. The code now work with both Olivine and CPX.[todo] further simplify the code.

    Before your first pull request:

For all pull requests:

For new features/models or changes of existing features:

bangerth commented 4 months ago

Just to make sure, you closed this pull request because you're going to break it into pieces?

magmaxt commented 3 months ago

Just to make sure, you closed this pull request because you're going to break it into pieces?

Sorry for the late reply, I completely missed your message and thanks for checking in! Yes, I am working on a cleaner version of this pull request based on Rene's advice and will reopen a PR this week.