Closed Grant-Block closed 3 months ago
Hi @jdannberg @naliboff, this PR builds off my other one, so it probably would be best to make sure the other one is wrapped up before doing too much more on this one. I just wanted to get this up!
Yes, you'll need to rebase to main before we can look at the changes (otherwise it's hard to tell which changes come from this PR and which ones are from the other one).
Hi @jdannberg and @naliboff, I rebased to main and squashed my commits here, so this PR is ready for comments. Thank you!
Hi @jdannberg, thanks for your comments! I'll push the changes up to the PR after doing any changes @naliboff might have, so I don't make too many more commits! My new test has identical results to rising_melt_blob_freezing, except for the solid viscosity, which is what I would expect from using a different solid material in this case.
/rebuild
Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.
This uses the KatzMantleMelting module to calculate reaction and melt terms as an option in the reactive_fluid_transport model. A test is included copying a MeltSimple test, but using a visco plastic solid material model.
Before your first pull request:
For all pull requests:
For new features/models or changes of existing features: