search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
218 stars 232 forks source link

BoundaryTractions::Interface has unused member geometry_model. #5797

Closed bangerth closed 1 month ago

bangerth commented 1 month ago

The interface class has a protected member variable geometry_model that, however, it never sets. Perhaps it is used by derived classes, but if so they should (i) store this variable themselves, (ii) even better access the geometry via the SimulatorAccess class. In other words, the variable just needs to be nuked.

(I'm not doing that right away because I'm missing around in this file in other ways right now.)

bangerth commented 1 month ago

I've got a patch for this, but it's queued up behind other stuff. Will submit once the other patches have cleared.