search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
217 stars 232 forks source link

Add world builder integration to CPO initial grains. #5826

Closed MFraters closed 3 weeks ago

MFraters commented 1 month ago

This pull request enables the use of the world builder to setup initial grain-sizes and initial grain orientations for different regions in the model.

I do still need to add tests. @Wang-yijun Can you also take a look at this to see if it works for you?

Wang-yijun commented 1 month ago

I've tested using initial textures from GWB on this branch. It works for me!

MFraters commented 1 month ago

@Wang-yijun Thanks for testing!

This pull request is now ready for review

MFraters commented 1 month ago

@gassmoeller I addressed your comments, but I didn't understand what you meant with one of them. This pull request works with the world builder which is part of aspect. With the changes @Wang-yijun made, better tests can be made, but that will have to wait until the new wold builder version is released and becomes part of aspect.

MFraters commented 3 weeks ago

@gassmoeller Thanks for the review. I have addressed your comments