search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
217 stars 232 forks source link

Make 'dim' unsigned. #5844

Closed bangerth closed 3 weeks ago

bangerth commented 1 month ago

I was asked why dim is signed. There is no good answer, and generally I'm of the opinion that we should not carry around past stuff just because. So let's fix this.

tjhei commented 1 month ago

This is not consistent with deal.II so I would prefer to keep dim as int. Compilers agree. :-)

MFraters commented 4 weeks ago

I do think it would make sense to change, but I agree that it would probably be a good idea to coordinate with dealii, given that there is a lot of overlap in the used types. Or is this not a problem?

bangerth commented 3 weeks ago

Let me close this before anyone else thinks that was a serious proposal :-)