search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
217 stars 232 forks source link

Backport fix gwb clang flags. #5849

Closed MFraters closed 3 weeks ago

MFraters commented 1 month ago

This is a backport of https://github.com/GeodynamicWorldBuilder/WorldBuilder/pull/739, which applies the fixes for the stricter clang flags. I did this by hand more or less, so hopefully I didn't miss anything.

@tjhei can you run this with your clang aspect version?

MFraters commented 3 weeks ago

I have addressed @tjhei latests comment in https://github.com/GeodynamicWorldBuilder/WorldBuilder/pull/739 here as well.

MFraters commented 3 weeks ago

@gassmoeller, I fixed the issue you found with the extra space before the template

MFraters commented 3 weeks ago

@gassmoeller, sorry that I missed a few. I think I got them all now, and I have addressed your other comments.

tjhei commented 3 weeks ago 
/ssd/aspect-git/contrib/world_builder/source/world_builder/utilities.cc:1193:48: warning: implicit conversion changes signedness: 'int' to 'unsigned int' [-Wsign-conversion]
 1193 |               unsigned int invalid_file_size = -1;