search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
217 stars 232 forks source link

Remove deprecated particle update function #5873

Closed gassmoeller closed 3 weeks ago

gassmoeller commented 3 weeks ago

We had an outdated particle update interface function, which was deprecated 4 years ago. In order to modernize the update interface as a first step I remove this function in this PR. Unfortunately, I didnt notice during review that the CPO particle plugins use this function (I do not know why we got no deprecation warnings?). Therefore I update the use of the update function in the CPO related particle plugins as well.

The header files contain a lot of copy-pasted documentation, let me know if you want me to remove that.

magmaxt commented 2 weeks ago

@MFraters @gassmoeller Somehow the inputfile.zip that used to work last week (e.g. with source code from PR #5804) no longer work with this updated version with error message below:

-- This is ASPECT -- -- The Advanced Solver for Planetary Evolution, Convection, and Tectonics. --

-- . version 2.6.0-pre (main, 48254be63) -- . using deal.II 9.5.1 -- . with 32 bit indices -- . with vectorization level 0 (disabled, 1 doubles, 64 bits) -- . using Trilinos 13.2.0 -- . using p4est 2.3.2 -- . using Geodynamic World Builder 0.6.0 -- . running in OPTIMIZED mode -- . running with 1 MPI process

Line <111> of file : No entry with name was declared in the current subsection.

Exception 'dealii::ExcMessage ("Invalid input parameter file.")' on rank 0 on processing: An error occurred in line <484> of file </Users/tian_bc/repos/github_magmaxt/aspect/source/main.cc> in function void parse_parameters(const std::string &, dealii::ParameterHandler &) The violated condition was: false Additional information: Invalid input parameter file.

MFraters commented 2 weeks ago

@magmaxt We are currently in the process of preparing for the ASPECT 3.0 release, where we are breaking a lot of things (see #5026).

In this case I think is has to do with that we merge #5394 today, which moves the particle section from post-process to it's own section. The pull request contains a script to update your prm file. I think it is this script: https://github.com/geodynamics/aspect/blob/main/contrib/utilities/update_prm_files.sh. @gassmoeller is that correct?

magmaxt commented 2 weeks ago

@magmaxt We are currently in the process of preparing for the ASPECT 3.0 release, where we are breaking a lot of things (see #5026).

In this case I think is has to do with that we merge #5394 today, which moves the particle section from post-process to it's own section. The pull request contains a script to update your prm file. I think it is this script: https://github.com/geodynamics/aspect/blob/main/contrib/utilities/update_prm_files.sh. @gassmoeller is that correct?

@MFraters Thanks for the fast response. Yes, I just tried the update_prm_files.sh, it works now.