search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
217 stars 232 forks source link

Cell wise grain size particle update #5874

Closed gassmoeller closed 2 weeks ago

gassmoeller commented 3 weeks ago

@jdannberg: This is a first try to play with the cell-wise particle update for grain size. I still get different test results then before, and the code is not very optimized, but it is a starting point for testing.

jdannberg commented 3 weeks ago

I compared to the current main for the grain_size_growth_one_cell_particles test (changed to 7 refinements): main: Particles: Update properties 0.445s your branch: Particles: Update properties 0.265s

and for an application case (grain_size_ridge test): main: Particles: Update properties 15.8s your branch: Particles: Update properties 12.9s

gassmoeller commented 2 weeks ago

Nice improvements! I addressed your comments and converted one more particle property to the new interface (composition). The other properties can be updated in a follow-up PR.

Everything should be ready for another review.

gassmoeller commented 2 weeks ago

I have removed the composition plugin from this PR, fixed the documentation issue and updated the tests. I have some ideas for further optimizations, but they can wait for a follow-up PR. If the testers are happy this is good to go from my side.