search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
217 stars 232 forks source link

Refactor defect correction and newton solver to standardize methods and output #5889

Closed MFraters closed 2 weeks ago

MFraters commented 3 weeks ago

I noticed that the (iterated advection and) defect correction and newton solver have diverged, both in output and code, which should not have happened. In this pull request I combine them and let the defect correction version call the newton one with a parameter to state that it is not using the newton solver. This should prevent these kind of issue in the future.

MFraters commented 3 weeks ago

This is now ready for review

MFraters commented 2 weeks ago

Thanks for the review @gassmoeller. I addressed your comments.