search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
217 stars 232 forks source link

Move particle plugin declarations to relative path instead of absolulte path. #5896

Closed MFraters closed 2 weeks ago

MFraters commented 2 weeks ago

Related to #5877. A first step for allowing multiple particle fields, by making the particle plugin path relative instead of absolute.

gassmoeller commented 2 weeks ago

Like discussed, I think it is not particularly beautiful, because the parameter parsing in the particle plugins now looks differently from all other plugins, but I think it is the only reasonable solution. Why do you only do this in the parse_parameters function and not in the declare_parameters function? I think they should at least look similar.

MFraters commented 2 weeks ago

I am doing it in both. I may have missed something? I am currently trying to fix the tests, which may show where I missed something. I will let you know as soon as I have fixed the tests and it is ready to review.

MFraters commented 2 weeks ago

This pull request is now ready for review. All testers passed, but I noticed some parts where not covered while debuging,so I also have added some new test :)

MFraters commented 2 weeks ago

@gassmoeller I have addressed your comments