search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
217 stars 232 forks source link

Remove particle update ghost parameter #5940

Open gassmoeller opened 1 week ago

gassmoeller commented 1 week ago

I think it was a bad choice to only update ghost particles if this parameter was set. It is inconsistent with the handling of FE degrees of freedom (where entries on ghost cells are always available), and by now both the linear and quadratic least squares interpolators require the ghost particles if their limiters are active. The new interpolator in #5815 also requires ghost particles in all models. Therefore and as part of #5568 I would suggest to remove the input parameter and update ghost particles unconditionally.

Note that I could keep the parameter and only change the default, and/or assert that the parameter is set to true if we want to stay more compatible with old parameter files. I would be open for discussion about that, I just thought I would start with the most radical solution and see what opinions are out there.

gassmoeller commented 4 days ago

Comment is fixed.

gassmoeller commented 22 hours ago

Test has been fixed as well.