geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
217 stars 232 forks source link

Avoid generator expression in custom target COMMENT text. #5944

Closed bangerth closed 5 days ago

bangerth commented 5 days ago

The COMMENT part of add_custom_target is shown as the message by make/ninja when a target is being built. Apparently, the string to be shown is evaluated at the time when add_custom_target is parsed, not when the target is actually built, and as a consequence cmake generator expressions are not evaluated but shown verbatim.

This leads to awkward screen messages in a case I introduced in one of my previous patches. Instead, show a message like this, which while not perfect is better than the awkward $<...> text:

[1/1] Creating symlink from aspect.exe.debug to './aspect'
tjhei commented 5 days ago

test failure seems unrelated.