search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
217 stars 232 forks source link

Push the variable that stores the active plugin names down to the base class. #5950

Closed bangerth closed 4 days ago

bangerth commented 5 days ago

In pursuance of #1775.

This is not particularly pretty. Some of the manager classes store a list of names of the plugins that are active in this manager, but some do not. Some used std::list<std::string>, some std::vector<std::string>. Some had accessor functions that returned a reference to the object (preserving the type :-( ).

This patch pushes the member variable down into the base class, but not yet the accessor functions. It is another incremental step, with the remaining steps listed in #1775 and left for the coming days or weeks.

tjhei commented 5 days ago

That didn't quite work. :-)

bangerth commented 5 days ago

I would have been surprised if it had...

bangerth commented 5 days ago

The Jenkins test fails because of

particle_world_index < simulator->particle_worlds.size()

which we've seen in other PRs today as well.

tjhei commented 5 days ago

Yes. Could you merge #5948?

bangerth commented 4 days ago

OK, works now.