geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
217 stars 232 forks source link

Poison the default constructed values of MeltOutputs #5954

Closed gassmoeller closed 5 days ago

gassmoeller commented 5 days ago

Similar to #5247. I saw this during the review of #5902. We currently have no good way to check if a material model fills the MeltOutputs, because they are default constructed (different from other AdditionalMaterialOutputs like ElasticOutputs). We should initialize them with signaling NaNs like other optional outputs, which then allows us to check after the call to the material model whether they have been properly filled.