geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
217 stars 232 forks source link

Rename plugin manager member functions. #5955

Closed bangerth closed 5 days ago

bangerth commented 5 days ago

In #5942, I renamed functions introduced in #5934, in pursuance of #1775. These were of the form ManagerBase::(get|has)_matching_plugin(), but these names are not well chosen because managers, by definition, know about many plugins and so the function name does not indicate that we are asking about active objects. (The documentation states that, however.) So let me rename these one more time to ManagerBase::(get|has)_matching_active_plugin() to make that clearer.

I noticed this because in the next step for #1775, I need to introduce member functions that, in the previous naming scheme, would be called get_plugins() and get_plugin_names(), but I think that's just plain confusing because we're not asking about the names of all plugins, but rather about the ones actually selected in the input file. I think that get_active_plugins() and get_active_plugin_names() is a better choice.