search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
227 stars 237 forks source link

Some pre-release tasks #6082

Closed gassmoeller closed 1 month ago

gassmoeller commented 1 month ago

Just going through some of our pre release tasks. I also updated the release checklist with a bit more instructions, and reordered it to separate tasks that can be done before the release from tasks that are directly related to the release process.

tjhei commented 1 month ago

Would you mind splitting into several PRs? The size of changes makes it hard to review (chrome is lagging).

gassmoeller commented 1 month ago

Sure, sorry for the mess in this PR. This has been split into the other PRs referencing this one (6085-6088). About the indentation: Yes, I think there are several options which indentation changes to accept or not accept. I was more conservative now in #6088 and kept more manual indentation. I just find it a bit annoying to go through a hundred chunks by hand and decide which ones to keep. Maybe we can come up with a better process?

tjhei commented 1 month ago

I just find it a bit annoying to go through a hundred chunks by hand and decide which ones to keep.

Yeah, it is. I am happy to do the task for now, if you want.

Maybe we can come up with a better process?

It is difficult to fix the script to detect all cases of intentional indentation. I guess one could teach it about @deprecated and @param, though.