search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
228 stars 237 forks source link

Crash when look up table does not cover the range #6100

Open RanpengLi opened 1 month ago

RanpengLi commented 1 month ago

I add an option to make the model crash when the coordinate value is out of the range of the look-up table. I also manually set it for entropy model to make sure the look-up table always cover the entropy-pressure range.

bangerth commented 1 month ago

There are also a number of failing tests:

The following tests FAILED:
    312 - entropy_initial_lookup (Failed)
    313 - entropy_initial_lookup_wb (Failed)
    314 - entropy_plasticity (Failed)

What do we want to do about these tests?

RanpengLi commented 4 weeks ago

There are also a number of failing tests:

The following tests FAILED:
  312 - entropy_initial_lookup (Failed)
  313 - entropy_initial_lookup_wb (Failed)
  314 - entropy_plasticity (Failed)

What do we want to do about these tests?

Hi Wolfgang @bangerth , thank you for looking at this pull request! I have modified it and addressed your comments.

For the failed test, 314 failed because the entropy range in the lookup table (600-3000) doesn't cover the model range (up to 3021). I have decreased the maximum entropy in this test setup and will also need to update the result.

For 312 and 313, the model is trying to look up data with pressure = 0, while the look-up table has a pressure range start from 0.25 bar. @lhy11009 Haoyuan, I am mentioning you because you made these two tests. Would it be ok if I just simply change the 0.25 bar to 0 bar in your data table?

For the entropy look-up method, we definitely want the lookup table to cover the full entropy-pressure range of the model. So the three failed tests shows the exact situation we want to avoid with this new assert throw ;)