search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
227 stars 237 forks source link

Enable deprecation warnings in tester #6108

Closed gassmoeller closed 3 weeks ago

gassmoeller commented 1 month ago

Related to #6106. This PR enables deprecation warnings in the no unity build tester.

gassmoeller commented 4 weeks ago

I started addressing our deprecation warnings. There are several dozen instances of parse_map_to_double_array left to update though :-(. I will see if I can get to them later this week.

gassmoeller commented 4 weeks ago

Ok, I think this one is ready. I included #6111 in this PR, it doesnt matter to me if we merge them as separate PRs or combined in this one, but this one requires the functionality of #6111. If the other one is merged first I can rebase this one if necessary.

How does this work? Where is options.property_name set?

options.property_name was set as the second argument in the constructor above. To avoid the confusion I now create the options object with an empty string, and then set the correct name before each call. This is easier to read.