search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
227 stars 237 forks source link

Fix unnecessary pressure normalization #6126

Closed gassmoeller closed 2 weeks ago

gassmoeller commented 2 weeks ago

This PR is continuing #6125 and is easier to review after that one has been merged. I do not see why we normalize the pressure solution in this place. Since the last solve the pressure has not been denormalized, it is already normalized. Normalizing again in this place overwrites the existing last_pressure_normalization_adjustment (likely with something close to 0).

gassmoeller commented 2 weeks ago

I rebased after #6125 was merged. I still think this PR makes sense, because the vector in question already contains normalized pressures. The test changes are small and mostly concern residuals or iterations counts (likely because the pressure normalization variable is overwritten by this operation).