search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
227 stars 237 forks source link

Fix the units for the darcy velocity postprocessor #6129

Closed danieldouglas92 closed 1 week ago

danieldouglas92 commented 2 weeks ago

Within the darcy velocity postprocessor, the multiplier which converts the units of the darcy velocity to years instead of seconds was not being multiplied by the solid velocity, this PR fixes this unit discrepancy.

danieldouglas92 commented 2 weeks ago

I'm not sure why the dealii-master tests suite is failing, but this seems like something outside of the scope of this PR?

gassmoeller commented 2 weeks ago

/rebuild

danieldouglas92 commented 2 weeks ago

There is actually a test for this postprocessor in darcy_convection_step.prm, but the reason this bug wasn't found in that test is that the solid velocity was 0! I could modify another test which uses the darcy field advection method with a non zero solid velocity though?

tjhei commented 2 weeks ago

I could modify another test

that would be great!

danieldouglas92 commented 2 weeks ago

I decided it would be best to just update the existing test and make the solid velocity non-zero, there wasn't an existing test where it would be clear to see that the solid velocity was properly being taken into account in the post-processing.

gassmoeller commented 1 week ago

/rebuild