search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
227 stars 237 forks source link

Fix newton solver in parallel #6139

Closed gassmoeller closed 1 week ago

gassmoeller commented 2 weeks ago

Fix a bug introduced in #6133. .add does not work for vectors with ghost entries, but operator *= and operator += do. This wasnt caught by any tests, because we had no tests for the Newton solver with line search in parallel. I converted two of the existing tests to be run in parallel.

tjhei commented 2 weeks ago

can you fix test output? Otherwise good to go.

gassmoeller commented 1 week ago

Yes, we had no Newton tests in parallel. I included the fix of this PR into #6135, because there I can fix it in a cleaner way (since I create the search direction vector anyway). I am going to close this PR and instead use #6135 for the fix.