search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
227 stars 237 forks source link

Add an assert to the darcy velocity postprocessor #6145

Closed danieldouglas92 closed 1 week ago

danieldouglas92 commented 1 week ago

While testing some models I saw that the darcy velocity postprocessor works even when you are not advecting a field with the darcy field advection method, which seems a little pointless to me. This PR just adds an assert to ensure that the porosity field is actually advected with the darcy field advection method.

danieldouglas92 commented 1 week ago

@gassmoeller Thanks for the review, and I think you're right, at some point this could be a situation that someone may want to deal with. I think we actually may have had this exact same conversation when I made this postprocessor originally 😅, I'll close this PR.