search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
224 stars 235 forks source link

S40RTS and SAVANI initial temperature models use "vs to density scaling" as parameter names #760

Closed bangerth closed 8 years ago

bangerth commented 8 years ago

We almost always use parameter names whose first letter is capitalized. In this case I think there isn't even much of an argument that it might be a symbol because people will probably have an easier time reading Vs over vs when thinking of the shear wave velocity.

It should be possible to rename these parameters in a backward compatible way by using the parameter aliases that were introduced a while back.

Shangxin-Liu commented 8 years ago

Just recalled this discussion from Newsletter on mailing list. I also changed the vs to Vs in the last commit patch controlling the max order. @bangerth

bangerth commented 8 years ago

OK. In general, keep each patch self-contained and to one issue. In other words, the correct procedure for the future would be to have one patch for the "vs vs. Vs" issue, and one for the issue discussed in #759 .

gassmoeller commented 8 years ago

I think this issue was solved by #759, and can be taken of the list for 1.4 . I will close it for now. If someone objects, feel free to reopen.

Shangxin-Liu commented 8 years ago

Yes. This has been solved.

On Wed, May 4, 2016 at 8:36 AM, Rene Gassmöller notifications@github.com wrote:

I think this issue was solved by #759 https://github.com/geodynamics/aspect/pull/759, and can be taken of the list for 1.4 . I will close it for now. If someone objects, feel free to reopen.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/geodynamics/aspect/issues/760#issuecomment-216848512