geodynamics / burnman

BurnMan is a library for modeling mantle thermodynamics and thermoelasticity constrained by mineral physics experiments.
https://geodynamics.github.io/burnman/
GNU General Public License v2.0
53 stars 41 forks source link

Tutorial step_3 test failure #215

Closed bobmyhill closed 8 years ago

bobmyhill commented 8 years ago

* End of file "/home/bob/projects/burnman/misc/ref/step_3.py.out" reached while trying to read line 1001. * File "step_3.py.tmp" has more lines than file "/home/bob/projects/burnman/misc/ref/step_3.py.out", *\ line 1001 is the last one read from file "step_3.py.tmp"

! step_3.py ... FAIL

Check: /home/bob/projects/burnman/tutorial/step_3.py.tmp /home/bob/projects/burnman/misc/ref/step_3.py.out

1001 <== /usr/lib/python2.7/dist-packages/matplotlib/axes/_base.py: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal

      ==>

* End of file "/home/bob/projects/burnman/misc/ref/step_3.py.out" reached while trying to read line 1001. * File "step_3.py.tmp" has more lines than file "/home/bob/projects/burnman/misc/ref/step_3.py.out", *\ line 1001 is the last one read from file "step_3.py.tmp"

+++ File "step_3.py.tmp" differs from file "/home/bob/projects/burnman/misc/ref/step_3.py.out" done

sannecottaar commented 8 years ago

I thought I committed a fix to this... Delete the first line of to .out file. On Dec 13, 2015 3:14 PM, "Bob Myhill" notifications@github.com wrote:

* End of file "/home/bob/projects/burnman/misc/ref/step_3.py.out" reached while trying to read line 1001. * File "step_3.py.tmp" has more lines than file "/home/bob/projects/burnman/misc/ref/step_3.py.out", *\ line 1001 is the last one read from file "step_3.py.tmp"

! step_3.py ... FAIL Check: /home/bob/projects/burnman/tutorial/step_3.py.tmp /home/bob/projects/burnman/misc/ref/step_3.py.out

1001 <== /usr/lib/python2.7/dist-packages/matplotlib/axes/_base.py:

UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal ==>

* End of file "/home/bob/projects/burnman/misc/ref/step_3.py.out" reached while trying to read line 1001. * File "step_3.py.tmp" has more lines than file "/home/bob/projects/burnman/misc/ref/step_3.py.out", *\ line 1001 is the last one read from file "step_3.py.tmp"

+++ File "step_3.py.tmp" differs from file "/home/bob/projects/burnman/misc/ref/step_3.py.out" done

— Reply to this email directly or view it on GitHub https://github.com/geodynamics/burnman/issues/215.

bobmyhill commented 8 years ago

What is the figure meant to look like? I don't see any histograms...

The problem is in the "aspect" variables in the calls to plt.imshow(). Changing aspect_ratio to 'auto' fixes the problem (see #216), although it won't look exactly as it did before.

ian-r-rose commented 8 years ago

The figure is meant to look kind of crappy as is. The idea is to optimize for the pv/fp ratio, and then assign some reasonable error bars to the parameters (the ones in there at the moment are way too small). It then generates 1000 realizations of the minerals in order to visualize the effect of the uncertainty.

TL;DR: increase the standard deviations on lines 70 and 71, you should start to see the histograms.

bobmyhill commented 8 years ago

Ok, as long as I wasn't meant to see anything! Thanks! I changed the values, and things appeared as you said. PR #216 should be all that's needed to fix the problem.

bobmyhill commented 8 years ago

Just seen your PR ... That way is also good!