geodynamics / burnman

BurnMan is a library for modeling mantle thermodynamics and thermoelasticity constrained by mineral physics experiments.
https://geodynamics.github.io/burnman/
GNU General Public License v2.0
53 stars 41 forks source link

sanitised solution init #514

Closed bobmyhill closed 1 year ago

bobmyhill commented 1 year ago

This PR removes a series of optional arguments to the Solution class __init__ function and replaces them with a solution_model argument, that takes a SolutionModel object.

This change introduces backwards-incompatibility, but it allows for the development of more SolutionModel types without having to add useless parameters to the Solution class __init__ function.