FIX: improve and fix PolynomialSolution

geodynamics / burnman

BurnMan is a library for modeling mantle thermodynamics and thermoelasticity constrained by mineral physics experiments.

https://geodynamics.github.io/burnman/

GNU General Public License v2.0

54 stars 41 forks source link

Closed bobmyhill closed 8 months ago

bobmyhill commented 8 months ago

This PR improves the PolynomialSolution by:

Changing the user input to give indices and exponents, rather than repeated indices for higher powers
Internally changing the first and second derivative calculations to be much more efficient and work quickly for high exponents.
Adding several tests, which would have caught a previously uncaught bug in the second derivative calculations

This PR is a breaking change, as it changes the behaviour of PolynomialSolution.