search

geodynamics / mineos

Mineos computes synthetic seismograms in a spherically symmetric non-rotating Earth by summing normal modes.
http://geodynamics.org/cig/software/mineos/
GNU General Public License v2.0
24 stars 19 forks source link

Add demo data into repository #12

Closed JarettBakerDunn closed 5 months ago

JarettBakerDunn commented 5 months ago

I copied the data from https://geodynamics.org/resources/mineos/supportingdocs into the repository in the directory demo-data. I also removed the submodule DEMO folder, I hope that won't make any problems.

JarettBakerDunn commented 5 months ago

Should I add the manual PDF from geodynamics.org to the repository as well? Currently the manual is only available in Lyx files in the repository.

ljhwang commented 5 months ago

I recall that we made a decision NOT to include the pdfs so as not to clutter up the repos. The rationale being that it could always be built.

If we continue to exclude, then the README will need to be updated and perhaps point to https://geodynamics.org/resources/mineos.

gassmoeller commented 5 months ago

Thanks for figuring this out, this should fix issues #9 and #11. But maybe you could put the data into a folder named DEMO instead of demo-data? That way all old references to the DEMO submodule would continue to work? Or was the data always in a directory called demo-data?

JarettBakerDunn commented 5 months ago

@gassmoeller I deleted the DEMO folder because it prevented me from cloning the repository because I couldn't reach the submodule. I don't have much experience with git submodules, so I'm not sure the best way to approach this. It looks like I could unlink the DEMO folder from the submodule and rename the demo-data folder to the original name, which was DEMO. But I don't know if unlinking the directory from the submodule would stop the old references from working.

ljhwang commented 5 months ago

I only see the directory DEMO referred to once and that is in the manual. I don't think you will break anything!