search

geodynamics / vq

Virtual Quake is a boundary element code designed to investigate long term fault system behavior and interactions between faults through stress transfer.
Other
12 stars 24 forks source link

Add apt noninteractive envvars to apt call #201

Closed tjesser-ucdavis-edu closed 6 years ago

tjesser-ucdavis-edu commented 6 years ago

DockerHub was able to build the Xenial buildenv, but I added them to both just to be safe.

I didn't use the ENV Dockerfile directive because, as the Docker documentation points out,

Note: Environment persistence can cause unexpected side effects. For example, setting ENV DEBIAN_FRONTEND noninteractive may confuse apt-get users on a Debian-based image. To set a value for a single command, use RUN = .

This is only a build environment, so if you feel strongly one way or the other, I'd be willing to change to using ENV.

tjesser-ucdavis-edu commented 6 years ago

Unfortunately, the build failure is due to the Jenkins server having issues with containers connecting to the internet. (Jenkins spins up a temporary container for each build.) Once #200 gets accepted, the build container won't have to make any outside network calls, and it should pass.

We've been struggling with this with Aspect as well. It's part of the reason I wanted to create the buildenv containers in the first place.

johnmaxwilson commented 6 years ago

200 is now merged

tjesser-ucdavis-edu commented 6 years ago

Great, the build is now passing.