search

geodynamics / vq

Virtual Quake is a boundary element code designed to investigate long term fault system behavior and interactions between faults through stress transfer.
Other
12 stars 24 forks source link

Add parallel build test in Bionic environment #203

Closed tjesser-ucdavis-edu closed 5 years ago

tjesser-ucdavis-edu commented 5 years ago

Depending on how Jenkins deals with parallel test results, this might not be worth merging. And it might not be worth testing on multiple environments anyway.

@johnmaxwilson I know you've been merging my PRs for the Jenkins build system, but are you fine with how it's working? As far as I know, you're currently the sole maintainer.

tjesser-ucdavis-edu commented 5 years ago

It looks like there's an issue with linking the HDF5 library when building the mesher on Ubuntu 18.04 (Bionic).

johnmaxwilson commented 5 years ago

@tjesser-ucdavis-edu I'm good with the recent changes, and I am indeed the sole maintainer. To a large extent I'm trusting you and CIG for the automated builds knowhow.

tjesser-ucdavis-edu commented 5 years ago

It seems like the DockerHub container autobuilds is working well. The DockerHub website provides good documentation on how they were built, the GitHub integration works well, and it's easy to get Jenkins to use them.

I guess the question is whether something needs to be changed in the Bionic container, or something needs to be changed in the VQ code.

johnmaxwilson commented 5 years ago

This is an issue that has cropped up frequently. We might not have the dev time to put towards it until the beginning of the new quarter (at which time we'll be training a new student to come on board to take over), but troubleshooting these and other HDF5 issues on the side of the source code is a top priority.

tjesser-ucdavis-edu commented 5 years ago

Just checking to see if the timeline for 18.04 support has changed.

johnmaxwilson commented 5 years ago

The consultant we talked to said this would likely be fixed with a simple addition of a -lhdf5 flag when compiling

tjesser-ucdavis-edu commented 5 years ago

This is ready for review, I think. I ended up reading through the HDF5 CMake documentation thanks to your suggestion.

The parallel builds seem to be working well, and now we know VirtualQuake doesn't have issues with newer packages or libraries. Let me know your thoughts.

johnmaxwilson commented 5 years ago

This looks great, thanks for checking through the cmake docs. Merging into base.