search

geoelectric / firefox-feedly-rss

Adds Feedly Cloud Reader as an option in Firefox's Subscribe dialog
Mozilla Public License 2.0
10 stars 8 forks source link

Please, declare seamonkey support #1

Open iav opened 11 years ago

iav commented 11 years ago

Hi

This addon charmly works with Seamonkey. The one change it need is to add 

em:targetApplication
    <Description>
        em:id{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}/em:id
        em:minVersion2.0/em:minVersion
        em:maxVersion2.*/em:maxVersion
    </Description>
/em:targetApplication

into install.rdf.

I want to propose a pull request, but see no install.rdf file there.

geoelectric commented 11 years ago

Trick is that the Addons SDK doesn't give direct access to the install.rdf file. I need to ask around and see if there's a good way to get that info in there without having to go around the system. There are a couple of workarounds I can think of, if I have to, but don't want to chance breaking forward compatibility when they auto-update the SDK for me.

iav commented 11 years ago

Maybe, kind of a "seamonkey compatible" checkbox some place?

geoelectric commented 11 years ago

I don't quite follow the suggestion--can you give more detail as to what you're thinking?

The problem is that Addons SDK extensions use a template install.rdf inside the SDK itself that has the targetApplication field predefined. I know you can hand-edit the template in order to change the compatible version range, and there's even an experimental command line option for cfx for using a completely different template directory (and thus different install.rdf).

If all I have to do is create a template with SeaMonkey's ID/range in there as well and point cfx at that, then I have no problem doing that. I just want to make sure this won't mess up any Firefox compatibility concerns or make me fail an AMO review.

Shouldn't take more than a few days for me to ask the right people and find out. If for some reason, having one extension for both Firefox and SeaMonkey doesn't look possible, you can always fork this and tweak it just for SeaMonkey, per MPL2, and submit it up to SeaMonkey's AMO site.

iav commented 11 years ago

That person is a John-Galt at irc channel #addons on irc server irc.mozilla.org (http://irc.mozilla.org/)

geoelectric commented 11 years ago

Cool, thanks for the lead!