geoelements / gns

Graph Network Simulator
https://www.geoelements.org/gns/
Other
124 stars 30 forks source link

JOSS Review #33

Closed WPettersson closed 1 year ago

WPettersson commented 1 year ago

Hello Krishna et al.,

Thank you for your submission to JOSS, I'm happy for the opportunity to review it. I'll use this issue as a meta-issue to track my commentary. I'll be raising other issues (and mentioning them here) for specific items I note as I review the paper and software.

osorensen commented 1 year ago

Nice to see that you opened issues here @WPettersson. I just add a link to the review here so we keep track: https://github.com/openjournals/joss-reviews/issues/5025

kks32 commented 1 year ago

Thanks @WPettersson and @osorensen I'm working on fixing them. Will do it ASAP.

WPettersson commented 1 year ago

All fixed, as far as I'm concerned. Well done on a nice job :)