geoelements / gns

Graph Network Simulator

https://www.geoelements.org/gns/

Other

124 stars 30 forks source link

Hydra yaml config #81

Closed kks32 closed 2 months ago

kks32 commented 2 months ago

Use yaml to configure settings rather than command line arguments:

[x] Define input file schema and validation
[x] Support resume flag
[x] Update README
[x] move constants to data section

Related Issues/PRs

80

yjchoi1 commented 2 months ago

Would it be better to add the configurations from metadata.json to config.yml? However, this might cause compatibility issues with the previous version, which explicitly reads from metadata.json.

Currently, metadata.json controls some of the important hyperparameters like n_message_passing, connectivity_raidus, nnode_in (optional) etc.

Other than these, everything looks good. I tested PR on my actual data for training, rollout, and rendering.

kks32 commented 2 months ago

Currently, metadata.json controls some of the important hyperparameters like n_message_passing, connectivity_raidus, nnode_in (optional) etc.

MLP configuration will be part of Configuration file in future PRs. This is planned for v2 to be able to switch between different types of MLPs/KANs