search

geoext / geoext2

GeoExt 2 — JavaScript Toolkit for Rich Web Mapping Applications
http://geoext.github.io/geoext2/
Other
142 stars 106 forks source link

Fix event forwarding for layername changes. #307

Closed marcjansen closed 9 years ago

marcjansen commented 9 years ago

Previously we wouldn't be notified when the name of a layer changed, as we erroneously compared e.property with 'nathis' instead of 'name' inside of onChangelayer. I think the original cause of this was a search and replace gone wrong in e2712c0ba605a9d35681d9560e3e.

This commit also adds a test for the event forwarding, so we don't get bitten again.

Please review.

bartvde commented 9 years ago

LGTM please merge if Travis agrees

marcjansen commented 9 years ago

Travis looks fine. Cheers for the review.