search

geoext / geoext2

GeoExt 2 — JavaScript Toolkit for Rich Web Mapping Applications
http://geoext.github.io/geoext2/
Other
142 stars 106 forks source link

Extjs5 #313

Closed KaiVolland closed 9 years ago

KaiVolland commented 9 years ago

Changed the inclusion method of the ExtJS-dependencies:

See commit messages for details.

marcjansen commented 9 years ago

Awesome work, @KaiVolland, very impressive!

With this in, we now have the headless tests running against v5 of ExtJS, which means the travis result is actually meaningfull for the work in the extjs-branch.

I especially like that we have a harmonized loading now of the baselibraries in tests (browser and headless) and in the examples.

I'll merge this now, thanks again (this'll take some time for me, as I need to do the merge manually)

marcjansen commented 9 years ago

Hey @chrismayer. We'll take your comments for any coming PR. This one is already merged. As the extjs5 branch is a work in progress I do not see any problems here.

Before we'll eventually merge extjs5 into master, a cleanup of the commits will surely happen.