geoext / geoext2

GeoExt 2 — JavaScript Toolkit for Rich Web Mapping Applications
http://geoext.github.io/geoext2/
Other
142 stars 106 forks source link

Adopt minimal Sencha Cmd package requirements #350

Closed bentrm closed 9 years ago

bentrm commented 9 years ago

This PR aims to be less intrusive than #302 while still adding support for Sencha CMD. It only adds one configuration file and some docs (which may be extended in the future).

To play nice with Cmd the following changes had to be made to the newly added package.json:

I tried it with an existing application (ExtJS 4.2.1) as well as with a newly generated test app (ExtJS 5.1).

marcjansen commented 9 years ago

Thanks for your continued work on this @bentrm.

/cc @KaiVolland I'd value your opinion on this very much (he is the expert for the sencha command).

marcjansen commented 9 years ago

From the diff I'd say this looks great! Let's wait for @KaiVolland's approval

KaiVolland commented 9 years ago

Looks good to me.

marcjansen commented 9 years ago

Cool. Thanks to both of you @bentrm & @KaiVolland