search

geoext / geoext2

GeoExt 2 — JavaScript Toolkit for Rich Web Mapping Applications
http://geoext.github.io/geoext2/
Other
142 stars 106 forks source link

Avoid too wide colums in TreePanel (ExtJS 5) #379

Closed chrismayer closed 8 years ago

chrismayer commented 8 years ago

This avoids 10000px wide colums in the TreePanel when working with ExtJS 5.

This happened because the Ext.isIE6 flag is gone in ExtJS 5, what always activated the IE6 workaround with setting the column width to 10000px. Since we do not support IE 6 I removed the ternary operator by setting the width to 100% which works for ExtJS 4 and 5.

marcjansen commented 8 years ago

Thanks for this, Chris. Why 100% and not null... or even completely remove the property?

chrismayer commented 8 years ago

Before setting the property to null I removed it at all, so the code gets cleaner. Can you have another look @marcjansen? Thanks!

marcjansen commented 8 years ago

:+1: thanks again. Please merge, Chris.