search

geofabrik / osmi_simple_views

source code powering the views "Highways", "Geometry", "Tagging" and "Places" of OpenStreetMap Inspector
GNU General Public License v3.0
5 stars 2 forks source link

landuse=cemetery gets no_feature_tag_ways #39

Open matkoniecz opened 2 years ago

matkoniecz commented 2 years ago

https://www.openstreetmap.org/way/846950041

https://www.openstreetmap.org/way/846953062 https://www.openstreetmap.org/way/846952375

https://wiki.openstreetmap.org/wiki/Tag:landuse=cemetery?uselang=en

https://resultmaps.neis-one.org/hdyc-osmi-issues?uid=1722488

2652. | WAY | 846950041 | tagging | no_feature_tag_ways (?) | 2021-02-08 23:47:54 | 98935750 -- | -- | -- | -- | -- | -- | -- 2653. | WAY | 846952375 | tagging | no_feature_tag_ways (?) | 2021-02-08 23:43:28 | 98934892 2654. | WAY | 846953062 | tagging | no_feature_tag_ways (?) | 2021-02-08 23:43:30 | 98934892
sekerob commented 9 months ago

Just an observation. touching many a cemetery adding walls which are 100% over here, landuse=cemetery is fine, only once had an issue with a pet cemetery that I can recollect. It could be the combo that sets this off. Found few days ago that area:highway=residential is OK, but when attaching a name it gives this same no feature issue. In your case the common seems the supplemental tag of cemetery=war_cemetery. Remove it and wait 24 hours for the report update to confirm.

PS Remembered, we have a big Canadian war cemetery south of Ortona with same tags but its defined as a multipolygon. Had same issue few years ago per the CS comment until changing it to a multipolygon. https://www.openstreetmap.org/relation/13454179

matkoniecz commented 9 months ago

Remove it and wait 24 hours for the report update to confirm.

This tag is correct. I see no reason to remove valid tags

sekerob commented 9 months ago

If you don't want to test to narrow this down near 2 years after the report, up to you.

matkoniecz commented 9 months ago

Testing in production is not acceptable, damaging real data is not acceptable.

If this repository has unit tests I would be happy to make a pull request. If that QA tool is running a test version using dev server I would be happy to make test cases there.

I will not vandalise OSM data to test how exactly this unsupported and abandoned software is broken.