Closed seime closed 8 months ago
It looks like your formatting made changes to lines you didn't actually change. Would be easier to read without this. Thanks for the PR and I'd be happy to test if it looks like @geoffdavis would support it getting merged!
It looks like your formatting made changes to lines you didn't actually change. Would be easier to read without this. Thanks for the PR and I'd be happy to test if it looks like @geoffdavis would support it getting merged!
Yes, I am aware. The formatter formatted everything as I wrote in the initial comment. You can test it by changing the ESPHome source to https://github.com/seime/esphome-mitsubishiheatpump
I've been testing this on my heat pump install, it seems to work well (I only have vertical vane control to test). Much better than my attempted implementation with a Number component (like tuya_number).
Closing in lieu of #109
HORIZONTAL
andBOTH
swing mode options in additon toOFF
andVERTICAL
Note: This PR is a bit rough around the edges - it has been almost 2 decades since I last worked with C/C++
Frankly I do not expect this PR to get merged especially due to the number of changed lines by the formatter, but I though maybe some users would like to try it out as it the features have been requested in several issues.