search

geoffdavis / esphome-mitsubishiheatpump

ESPHome Climate Component for Mitsubishi Heatpumps using direct serial connection
BSD 2-Clause "Simplified" License
560 stars 153 forks source link

External updates from IR remote reverted #52

Closed jsn-0 closed 2 years ago

jsn-0 commented 2 years ago

According to the readme in SwiCago/HeatPump, settings made externally to the heat pump settings via the IR remote will be automatically reverted each time sync() is called unless enableExternalUpdate() is called to allow it.

Is that the case with this implementation or am I missing something? Thanks so much for your work on this!

jamescadd commented 2 years ago

I'd also like to be able to allow the IR remote to be used alongside Home Assistant, nice catch! It looks easy enough to add the call during setup and see if it works, though I did wonder if there was something larger going on with the flow of settings from hp to ESPHome based on this comment that could cause an issue:

https://github.com/geoffdavis/esphome-mitsubishiheatpump/blob/ac207f52d925f568dc6d7ce6357b0be2ae50d525/components/mitsubishi_heatpump/espmhp.cpp#L257

geoffdavis commented 2 years ago

As currently implemented, if I change things with my IR remote, ESPHome sees the changes and updates Home Assistant. No overriding of the IR remote calls occurs unless explicitly requested.