search

geoffdavis / esphome-mitsubishiheatpump

ESPHome Climate Component for Mitsubishi Heatpumps using direct serial connection
BSD 2-Clause "Simplified" License
560 stars 153 forks source link

SoftwareSerial Revisit #53

Open Matchlighter opened 2 years ago

Matchlighter commented 2 years ago

I was looking at the ESPHome UART implementation and noticed that it now has support for EVEN parity (https://github.com/esphome/esphome/blob/5026bc7a780919cb88e510b82acd5883417e730c/esphome/components/uart/uart_component_esp8266.cpp#L237). It looks like it was added ~2 years ago, so maybe right after you wrote this project (don't you love when that happens?). Do you recall if there were any other blockers besides the parity to using Software UART? If not, would you consider a PR?

geoffdavis commented 2 years ago

This would need to be coordinated with the underlying SwiCago/heatpump library, as I believe there was some difficulty in convincing that library to use anything but a physical UART from the Arduino codebase.

I'd welcome a PR.