geoffdavis / esphome-mitsubishiheatpump

ESPHome Climate Component for Mitsubishi Heatpumps using direct serial connection
BSD 2-Clause "Simplified" License
560 stars 153 forks source link

Optimistically report changes to esphome #7

Closed pgenera closed 4 years ago

pgenera commented 4 years ago

this makes two changes:

jamescadd commented 4 years ago

Just tested this briefly and it works well for me - much better experience in the UI for both the normal HA thermostat and simple thermostat. I'll continue using it and note any issues, but for now I think it would be a welcome improvement - thanks for this!

geoffdavis commented 4 years ago

Thanks, let me give it a shot on my system here.

geoffdavis commented 4 years ago

This looks great. I like the responsiveness of the UI, even if it still acts a little jumpy doing the conversions from F to C to F again. I had hesitated to implement the optimistic state changes, but it looks like it corrects itself just fine if the command doesn't take effect for whatever reason.