search

geoffdavis / esphome-mitsubishiheatpump

ESPHome Climate Component for Mitsubishi Heatpumps using direct serial connection
BSD 2-Clause "Simplified" License
588 stars 158 forks source link

Update SwiCago/HeatPump to latest commit #74

Closed grischard closed 2 years ago

grischard commented 2 years ago

Fixes #70. Difference is https://github.com/SwiCago/HeatPump/pull/182.

grischard commented 2 years ago

Well, compared to #68 it compiles at least. I'll try it on an actual unit soon.

@juan11perez and @dwildstr, you've shown interest in this in the past, would you like to test it too, by temporarily changing the external_components: part to - source: github://grischard/esphome-mitsubishiheatpump@Update-SwiCago/HeatPump ?

juan11perez commented 2 years ago

@grischard Sure, thanks. It's only the firmware rebuild? I saw in your previous note pin change.

grischard commented 2 years ago

@juan11perez yes, a simple rebuild telling esphome to grab the component from my forked branch instead of the main one.

dwildstr commented 2 years ago

I've installed it on my two pumps. For reference I'm running generic-knockoff D1 Mini boards, controlling MSZ-GE09NA pumps, and using ESPHome 2022.10.1 and controlling them with Home Assistant. Thus far it seems to work OK, but I haven't really done much beyond installing it.

juan11perez commented 2 years ago

@grischard I've installed on one of my horizontal ducted units (PEY-SM36JAl ) and it's running fine. I'm using an ESP32S.

I installed ESP32U (with antenna) in other units and just couldn't get the geoffdavies repo to work. It would send the commands, but it could not read the feedback, and I tried all 3 UART options and combinations.

However, I installed Tasmota in the same boards and it's working very well.

I'll try your repo on one of these ESP32U and revert.

grischard commented 2 years ago

I had no idea Tasmota had support for these Mitsubishi units! I don't expect the code changes in https://github.com/SwiCago/HeatPump/pull/182 to make a big difference to your issue, but am curious how it goes.

geoffdavis commented 2 years ago

Looking at this now. Let me make a test on one of my units.

geoffdavis commented 2 years ago

@grischard As far as I can tell, this looks like it works ok.

For some reason I thought the 1.0.0 API of SwiCago/HeatPump made some big API changes. My initial tests at least didn't work, but I must have had fat fingers.

I'll go ahead and mark this ready for review and merge it.