geoffhumphrey / brewcompetitiononlineentry

https://brewingcompetitions.com
78 stars 79 forks source link

Enhancement: Stripe integration #1222

Open cgspeck opened 3 years ago

cgspeck commented 3 years ago

Version: master

Installation URL: https://comps.westgatebrewers.org (currently password protected)

Is your installation hosted on brewcompetition.com or brewcomp.com? No

Description of Issue:

I'm a committee member of Westgate Brewers and we are looking at adopting your software for our annual Stout Comp.

I also happen to be a software engineer.

Would you be open to having Stripe integration added to this project as an alternative to/in addition to PayPal?

Stripe allows payment via Apple pay, Google pay in addition to debit/credit cards.

I also know first-handly that PayPal does, with little warning suspend customer accounts and also that their guest check out is broken.

I have experience integrating against Stripe and could look into this, if you indicate you'd welcome such a contribution.

For enhancements, please prepend "Enhancement - " to the title. For issues/bugs, please prepend the BCOE&M version number the title.

geoffhumphrey commented 3 years ago

Hi @cgspeck. Absolutely open to it - always good to provide an alternative to PayPal. I'd suggest forking the project and integrating where you can, but to keep the Stripe-specific coding and processing as separate as possible. Also, I have to say that I'm certainly not a software engineer, and to please excuse any clugy code - payments were one of the first integrations made with the application when I was relatively new to php. Most of the code hasn't been seriously evaluated or revised for a good long while, so there may be some room for improvement. :)

grahamb commented 3 years ago

VanBrewers would love to see this as well; we had our PayPal account locked without any warning and for no reason, and it took over a year to get it back. We've moved to Stripe for our membership payments but have to keep a PayPal account running for competitions, and have to transfer the money out immediately lest PayPal screw us over again.

cgspeck commented 3 years ago

I've made a start on this in my fork.

PeterSteinberg commented 2 years ago

I'd also like to see this feature.

You host our installation: https://mhtg.brewcompetition.com/

jangevaare commented 2 years ago

I noticed that recently this file was added to the repo - is this functional or testable now?

https://github.com/geoffhumphrey/brewcompetitiononlineentry/blob/master/includes/stripe_payment.inc.php

geoffhumphrey commented 2 years ago

Unfortunately, no. This was an oversight. It was simply me getting some testing going - the file shouldn't have been included in a commit - it's definitely not functional.

cgspeck commented 2 years ago

I've had to abandon my effort on this - there were too many changes in the code from when I started on this a year ago to the current master. I don't have time to resolve the changes and fix all the errors, unfortunately :-( .