geoffhumphrey / brewcompetitiononlineentry

https://brewingcompetitions.com
78 stars 80 forks source link

BCOE&M 2.3.0 Best brewer calculation is weird #1243

Open definiteopinions opened 2 years ago

definiteopinions commented 2 years ago

Version: BCOE&M 2.3.0

Installation URL: https://aotearoa.brewcompetition.com/

Is your installation hosted on brewcompetition.com or brewcomp.com? Yes

Description of Issue: Our Best Brewer (Champion Brewer) is calculated by 3 points for a first place, 2 for second, 1 for third. The winner got 3 first, 1 second, 1 third which should total up to 12 points. However the number displayed in the home page results is 12.05 (actual calculated value 12.04530356).

ercousin commented 2 years ago

I believe the decimals in Best Brewer calculations are used for tie-breaking. You must have a tie breaking rule enabled, perhaps this one: image

definiteopinions commented 2 years ago

OK thanks. We do have tie-breaks, maximum and minimum score, I think. I didn't consider that they would be in use since the second place brewer had 8 points, so no chance of a tie. Still looks messy though.