geofflay
commented
5 years ago Hi, thank you very much for your comments, I really appreciate them. Regarding specific comments, I wanted to say that for: _"I would highly recommend to add checkpoint after each function. It not only helps me to valid your code, but also helps you to debug the code by yourself. For example, after defining function get_average_sentence_length, just simply add a checkpoint get_average_sentencelength("hi, my name is geofflay!") to see the results."
I actually did do this throughout whilst I was developing the code, but I wanted to submit a clean file to you so, once I got everything working, I took out all of the checkpoint tests. Its good to know that this is recommended practice.
"Please use triple quotes for multi-line strings."
Yes, that is a good idea. I forgot to do that, and realise that I should have done.
Thanks for taking the time to provide feedback.
Regards,
Geoff
Criteria 1: Valid Python Code Score Level: 4 (exceeds expectations) Comment(s): Code included runs without any errors. I would highly recommend to add checkpoint after each function. It not only helps me to valid your code, but also helps you to debug the code by yourself. For example, after defining function get_average_sentence_length, just simply add a checkpoint get_average_sentence_length("hi, my name is geofflay!") to see the results.
Criteria 2: Implementation of Project Requirements Score Level: 4 (exceeds expectations) Comment(s): Code produces the suite of functions and classes required of it and calls them in an appropriate order. Great job calling the functions first before you call the class TextSample.
Criteria 3: Software Architecture Score Level: 4 (exceeds expectations) Comment(s): Code is separated into distinct classes and functions each which are invoked for their own purposes.
Criteria 4: Uses Python Language Features Score Level: 3 (Exceeds expectations) Comment(s): Code uses language features appropriately. If a task can be solved with a Python language feature, it is. Please use triple quotes for multi-line strings.
Criteria 5: Produces Accurate Output Score Level: 4 (Exceeds expectations) Comment(s): Code output is accurate.
Overall Score: 20/20 Overall great job! Keep up the good work!