geoidesic / foundryvtt-actor-studio

A FoundryVTT module for creating Actors
MIT License
8 stars 4 forks source link

### Bug Report: Issue with Subclass Selection #84

Closed Zarhog closed 2 months ago

Zarhog commented 3 months ago

Title: Subclass Selection Required at Level 1 for All Classes, Preventing Progression for Classes with Later Subclass Options

Description: In the "Actor Studio" mod for Foundry VTT, subclass selection is currently enforced at level 1 for all classes. This creates an issue for classes that do not receive their subclass until level 2 or 3, as there is no option to defer this choice. If no subclass is selected at level 1, the character creation process halts at 80%, preventing completion. Additionally, if the mod lacks sources for subclasses, the selection option is hidden, leaving users unable to finalize character creation.

Expected Behavior:

Actual Behavior:

Steps to Reproduce:

  1. Create a new character using the "Actor Studio" mod.
  2. Select a class that typically acquires a subclass at level 2 or 3 (e.g., Fighter, Rogue, Wizard).
  3. Attempt to skip subclass selection at level 1.
  4. Observe that the character creation process is blocked at 80%.
  5. Repeat the process with a class that does not receive subclasses until level 2 or 3, and no subclass sources available.

Impact: This issue blocks users from completing character creation for classes that receive subclasses at higher levels, leading to frustration and incomplete character setups. It also affects users without available subclass sources by preventing progress entirely.

Suggested Fixes:

System Information:

image

geoidesic commented 3 months ago

I think you've made some faulty assumptions about what's happening.

The fact that the subclass wasn't appearing isn't to do with the levels, it's just a bug that would only manifest under certain weird race conditions.

Hopefully that's been addressed now in release 1.3.4

Please check that you have updated to the latest FoundryVTT (v12 stable 330) as there was a bug in their richHTML editor which may have been causing these race conditions in earlier versions of foundry under the following conditions:

If the HTML content for the class contains links to missing compendiums, then it would cause errors which could cause race conditions.

geoidesic commented 3 months ago

Re-reading your ticket though, there may be an additional issue here...

Are you saying that there are cases where you wouldn't expect players to select the subclass at level 1?

If so, Actor Studio doesn't currently support that, no. The assumption is that, even though technically the subclass only kicks in at level 3, that you would select it for your character at level one, rather than deferring the selection till level three. The desire for deferment didn't occur to me.

I don't think the Level Up feature supports that idea either – it only supports adding classes, not subclasses.

geoidesic commented 2 months ago

@Zarhog is this now resolved. If so, please close the ticket.

geoidesic commented 2 months ago

I'm assuming this is resolved. You can request that I re-open the ticket if not. This may be related to #94