geokit / geokit-rails

Official Geokit plugin for Rails/ActiveRecord. Provides location-based goodness for your Rails app. Requires the Geokit gem.

MIT License

1.57k stars 245 forks source link

Wrapping drop/add in a transaction doesn't hurt #108

Closed kwerle closed 8 years ago

kwerle commented 8 years ago

106

Wrapping the drop/add function works in that I was unable to reproduce the situation where I had one instance of the app drop the function while another was trying to execute. This is an infrequent occurrence and my testing was by no means exhaustive.

My confidence is high that this is at least harmless and at best addresses the issue.

coveralls commented 8 years ago

Coverage remained the same at 48.79% when pulling 1c6af01499ca2bc1d9701648c048bf5f2bca33c2 on kwerle:feature/transaction into eb777e22708814afe4464e06dcfaa8173cb259c9 on geokit:master.