Support for the postgis adapter

geokit / geokit-rails

Official Geokit plugin for Rails/ActiveRecord. Provides location-based goodness for your Rails app. Requires the Geokit gem.

MIT License

1.57k stars 245 forks source link

Support for the postgis adapter #117

Closed babasbot closed 7 years ago

babasbot commented 7 years ago

The activerecord-postgis-adapter provides access to features of the PostGIS geospatial database from ActiveRecord. It extends the standard postgresql adapter to provide support for the spatial data types and features added by the PostGIS extension.

Changelog

Adds support for the postgis adapter.

Closes #116

coveralls commented 7 years ago

Coverage decreased (-0.6%) to 48.81% when pulling b6854d4b2592ae8dabe9f9fdcaf6ed81c812e442 on babasbot:feature/postgis-adapter into 2a5dc8b5c6aa6ecd0f41886a4fa32c64dfddbbce on geokit:master.

coveralls commented 7 years ago

Coverage remained the same at 49.398% when pulling b6854d4b2592ae8dabe9f9fdcaf6ed81c812e442 on babasbot:feature/postgis-adapter into 2a5dc8b5c6aa6ecd0f41886a4fa32c64dfddbbce on geokit:master.

coveralls commented 7 years ago

Coverage remained the same at 49.398% when pulling b6854d4b2592ae8dabe9f9fdcaf6ed81c812e442 on babasbot:feature/postgis-adapter into 2a5dc8b5c6aa6ecd0f41886a4fa32c64dfddbbce on geokit:master.

ylecuyer commented 7 years ago

Why use PostGIS if you don't use the provided functions ST_Distance ST_Distance_Sphere...

mnoack commented 7 years ago

Sorry @babasbot for not getting around to this. I've rebuilt the PR so it's now passing, the last remaining issues stopping me merging it are that it reduces coverage (so we should have a test to ensure this code doesn't just work now, but works well into the future).

And finally it would be good to address the comment made by another user here.

But otherwise I'm happy to merge.

mnoack commented 7 years ago

Sorry @babasbot - Closing this as it hasn't been active. Feel free to write the test case and I'm happy to re-look at it (and most likely merge it)

jon-sully commented 5 months ago

I too ended up forking this repo just to add the duplicate postgis file. Worked fine. Given the dynamic require, there's no way to monkey-patch this from a code level — had to do the full fork process.